search

jonbartels / mirth-connect-dashboard-count

A Mirth Connect plugin to show the counts of channels in channel groups.
Mozilla Public License 2.0
11 stars 3 forks source link

Channel Columns dont work due to upstream MC issue #1

Open jonbartels opened 2 years ago

jonbartels commented 2 years ago

https://github.com/nextgenhealthcare/connect/issues/5171 breaks the channel columns.

Add a README and remove the annotation so the channel columns dont package.

yimengZJl commented 2 years ago

image I'm not sure if that's okay

jonbartels commented 2 years ago

@yimengZJl I think you are right.

Try replacing the Engine Controller with a Channel Controller and see what happens.

yimengZJl commented 2 years ago

@jonbartels I tried. Channels couldn't load ，Same thing as this

jonbartels commented 2 years ago

Then try the fix I suggested at https://github.com/jonbartels/mirth-connect-dashboard-count/issues/5#issuecomment-1132844800 .

jonbartels commented 1 year ago

https://github.com/nextgenhealthcare/connect/issues/5171 has been fixed and a commit has been pushed to https://github.com/nextgenhealthcare/connect/commit/ed40e3466c97ee138cb52f39dbd6cc4fc2024e83

To verify this fix I need to:

jonbartels commented 1 year ago

The channel list part of plugin does not work but I think this is a bug in the plugin.

The error from Mirth is not thrown any more. The channel list appears even if the plugin errors. The channel column simply doesnt display at all instead of throwing errors.

jonbartels commented 10 months ago

The ChannelColumnPlugin no longer errors, but it does not work cleanly either. There is a problem with the load order.

Copying some notes from Slack:


  [1 hour ago](https://mirthconnect.slack.com/archives/C01QLL13HNU/p1704038244590229)
From what I can tell com.jonbartels.mirthdashboard.ChannelListeningPortColumn#getColumnHeader is never called by [https://github.com/nextgenhealthcare/connect/blob/cf08dfbd133be8de931a4ca950a377b4[…]72921c/client/src/com/mirth/connect/client/ui/ChannelPanel.java](https://github.com/nextgenhealthcare/connect/blob/cf08dfbd133be8de931a4ca950a377b44d72921c/client/src/com/mirth/connect/client/ui/ChannelPanel.java#L3039)
I see it calling
In tableUpdate...
In getTableData...
So I know my plugin is loaded and the channel column class is loaded.
The Dashboard columns work but the Channel columns do not.  Any ideas before I run Mirth in Java debug mode and trace it down?
4 replies

jonb
  [17 minutes ago](https://mirthconnect.slack.com/archives/C01QLL13HNU/p1704040730205199?thread_ts=1704038244.590229&cid=C01QLL13HNU)
I think I found the problem. The channel panel code runs BEFORE the extensions are loaded by the client

jonb
  [8 minutes ago](https://mirthconnect.slack.com/archives/C01QLL13HNU/p1704041285428919?thread_ts=1704038244.590229&cid=C01QLL13HNU)
Repro steps:
Launch MCA with debugging (change the memory value in MCAL to 512m  -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005
BEFORE logging in, connect your IDE to the debugging port
Set breakpoints in ChannelPanel.java where it adds the headers
Set breakpoints in LoadedExtensions.java where it adds the channel column plugins
The LoadedExtensions code never returns any loaded plugins at this point
After you move past the breakpoints you will see the MCA status message "loading extensions"
The Channel Column plugin point can't ever work

jonb
  [6 minutes ago](https://mirthconnect.slack.com/archives/C01QLL13HNU/p1704041388016779?thread_ts=1704038244.590229&cid=C01QLL13HNU)
OMG. So then
Log out of MC (dont quit, just log out)
Log in again
Channel Column plugin works now

jonb
  [6 minutes ago](https://mirthconnect.slack.com/archives/C01QLL13HNU/p1704041410410729?thread_ts=1704038244.590229&cid=C01QLL13HNU)
I'm checking to see if the extension start is somehow called before the channel panel loads so I can pre-load the extension```
jonbartels commented 10 months ago

My plugin no longer errors but it does not work because of a new issue - https://github.com/nextgenhealthcare/connect/issues/6046