fix: exit process with error code when unexpected config provided in YAML - Githubissues

jonbhanson / flutter_native_splash

Automatically generates native code for adding splash screens in Android and iOS. Customize with specific platform, background color and splash image.

https://pub.dev/packages/flutter_native_splash

MIT License

1.36k stars 215 forks source link

fix: exit process with error code when unexpected config provided in YAML #657

Closed smit-ghl closed 10 months ago

smit-ghl commented 10 months ago

Current behavior:

When provided invalid configuration in YAML for flutter_native_splash and ran dart run flutter_native_splash:create command, process exits with 0 code. This indicates process completed successfully without any issue.

What's change:

With this PR, the process exits with error code to indicate the command failed to get executed.

🐞 This PR fixes #656 .

CI/CD pipeline wasn't failing before due to process completed with success code (`exit(0)`):

CI-CD-pipeline-before-change

CI/CD pipeline fails with this PR changes because process now exits with error (`exit(1)`):

CI-CD-pipeline-after-change