search

jonbiemond / BCIT-Flex

A website for easily navigating BCIT courses and offerings.
https://www.bcitflex.tech
MIT License
10 stars 8 forks source link

Add search feature #61

Closed jonbiemond closed 8 months ago

jonbiemond commented 9 months ago

Add the ability to search by course name.

Dominik26-1 commented 8 months ago

I would like to contribute to this issue especially for backend part. Can you assign to me and add more details? @jonbiemond

jonbiemond commented 8 months ago

@Dominik26-1 I've assigned you! Feel free to focus on just the backend for now. I'll add more details soon.

Dominik26-1 commented 8 months ago

I think, its so far so clear. I've already started on it. Can you please give me permission to push to my created development branch and create PR.

remote: Permission to jonbiemond/BCIT-Flex.git denied to Dominik26-1. fatal: unable to access 'https://github.com/jonbiemond/BCIT-Flex.git/'

jonbiemond commented 8 months ago

Hi @Dominik26-1 , instead of pushing changes directly to this repo could you please create a fork and make the changes there?

See details on how to create a fork here: https://docs.github.com/en/get-started/quickstart/fork-a-repo And since you've already made the changes in a clone of this repo, here's how you can make the new fork the remote for your local version: https://docs.github.com/en/get-started/quickstart/fork-a-repo

jonbiemond commented 8 months ago

Hey @Dominik26-1, I look forward to seeing your PR! Is there anything I can help with?

Dominik26-1 commented 8 months ago

Hi, I had locally prepared PR but I noticed you changed main code so need to update my changes with yours.

jonbiemond commented 8 months ago

Hey @Dominik26-1, don't worry about that for now. Let's leave it as the very last step before merging. I can also help resolve any conflicts.

Dominik26-1 commented 8 months ago

I created PR some minutes ago, so you can have a look (add some functionality for not exact matching, make sense for me to not only return records with the same word)