search

jonbmartin / pulpy

Pulses in Python
GNU General Public License v3.0
3 stars 2 forks source link

PyPi package does not install dependencies #11

Open bwheelz36 opened 1 month ago

bwheelz36 commented 1 month ago

Continuing review for https://github.com/openjournals/joss-reviews/issues/6586

I've noticed that although the package dependencies are listed in requirements.txt, this is not linked to the packaing of the code. As such, doing pip install pulpy does not install the dependencies required to run the code.

bwheelz36 commented 1 month ago

this also applies if one does pip install -e . as suggested in the readme

bwheelz36 commented 1 month ago

(this comes back to the packaging being pretty confusing. tbh, i'd recommend starting from scratch here and just using something like poetry)