jonbmartin / pulpy

Pulses in Python
GNU General Public License v3.0
3 stars 2 forks source link

Putting issues in this PR for convenience. #14

Open curtcorum opened 1 month ago

curtcorum commented 1 month ago

https://github.com/openjournals/joss-reviews/issues/6586

Please consider adding conda support. For example, all my current projects use conda for dependencies (e.g. sigpy), since it integrates dependencies more reliably. For replication, pip is sufficient, but for actual usage and incorporating as a dependency, conda would greatly expand utility.

https://medium.com/analytics-vidhya/publish-a-python-package-to-conda-b352eb0bcb2e

curtcorum commented 1 month ago

Install for development seems ok. I forked the repository before installing.

(pulpy) curt@green:~/src/pulpy$ pip install -e .
Obtaining file:///mnt/Champaign_4TB_EX/Champaign%20Dropbox/Curt%20Corum/src_green/pulpy
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
    Preparing wheel metadata ... done
Installing collected packages: pulpy
  Attempting uninstall: pulpy
    Found existing installation: pulpy 1.8.1
    Uninstalling pulpy-1.8.1:
      Successfully uninstalled pulpy-1.8.1
  Running setup.py develop for pulpy
Successfully installed pulpy

In installing the development dependencies there seems to be some path issues.

(pulpy) curt@green:~/src/pulpy$ pip install coverage ruff sphinx sphinx_rtd_theme isort
Collecting coverage
  Downloading coverage-7.5.3-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (232 kB)
     |████████████████████████████████| 232 kB 1.4 MB/s 
Collecting ruff
  Downloading ruff-0.4.7-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (8.8 MB)
     |████████████████████████████████| 8.8 MB 17.2 MB/s 
Collecting sphinx
  Downloading sphinx-7.1.2-py3-none-any.whl (3.2 MB)
     |████████████████████████████████| 3.2 MB 64.0 MB/s 
Collecting sphinx_rtd_theme
  Downloading sphinx_rtd_theme-2.0.0-py2.py3-none-any.whl (2.8 MB)
     |████████████████████████████████| 2.8 MB 63.2 MB/s 
Collecting isort
  Downloading isort-5.13.2-py3-none-any.whl (92 kB)
     |████████████████████████████████| 92 kB 282 kB/s 
Collecting sphinxcontrib-serializinghtml>=1.1.5
  Downloading sphinxcontrib_serializinghtml-1.1.5-py2.py3-none-any.whl (94 kB)
     |████████████████████████████████| 94 kB 4.1 MB/s 
Collecting Pygments>=2.13
  Downloading pygments-2.18.0-py3-none-any.whl (1.2 MB)
     |████████████████████████████████| 1.2 MB 70.2 MB/s 
Collecting docutils<0.21,>=0.18.1
  Downloading docutils-0.20.1-py3-none-any.whl (572 kB)
     |████████████████████████████████| 572 kB 50.4 MB/s 
Collecting packaging>=21.0
  Downloading packaging-24.0-py3-none-any.whl (53 kB)
     |████████████████████████████████| 53 kB 3.2 MB/s 
Collecting importlib-metadata>=4.8; python_version < "3.10"
  Downloading importlib_metadata-7.1.0-py3-none-any.whl (24 kB)
Collecting sphinxcontrib-htmlhelp>=2.0.0
  Downloading sphinxcontrib_htmlhelp-2.0.1-py3-none-any.whl (99 kB)
     |████████████████████████████████| 99 kB 15.2 MB/s 
Collecting sphinxcontrib-applehelp
  Downloading sphinxcontrib_applehelp-1.0.4-py3-none-any.whl (120 kB)
     |████████████████████████████████| 120 kB 88.8 MB/s 
Collecting babel>=2.9
  Downloading Babel-2.15.0-py3-none-any.whl (9.6 MB)
     |████████████████████████████████| 9.6 MB 73.2 MB/s 
Collecting sphinxcontrib-jsmath
  Downloading sphinxcontrib_jsmath-1.0.1-py2.py3-none-any.whl (5.1 kB)
Collecting imagesize>=1.3
  Downloading imagesize-1.4.1-py2.py3-none-any.whl (8.8 kB)
Collecting sphinxcontrib-devhelp
  Downloading sphinxcontrib_devhelp-1.0.2-py2.py3-none-any.whl (84 kB)
     |████████████████████████████████| 84 kB 5.5 MB/s 
Collecting alabaster<0.8,>=0.7
  Downloading alabaster-0.7.13-py3-none-any.whl (13 kB)
Collecting sphinxcontrib-qthelp
  Downloading sphinxcontrib_qthelp-1.0.3-py2.py3-none-any.whl (90 kB)
     |████████████████████████████████| 90 kB 15.3 MB/s 
Collecting Jinja2>=3.0
  Downloading jinja2-3.1.4-py3-none-any.whl (133 kB)
     |████████████████████████████████| 133 kB 69.3 MB/s 
Collecting requests>=2.25.0
  Downloading requests-2.32.3-py3-none-any.whl (64 kB)
     |████████████████████████████████| 64 kB 5.5 MB/s 
Collecting snowballstemmer>=2.0
  Downloading snowballstemmer-2.2.0-py2.py3-none-any.whl (93 kB)
     |████████████████████████████████| 93 kB 2.0 MB/s 
Collecting sphinxcontrib-jquery<5,>=4
  Downloading sphinxcontrib_jquery-4.1-py2.py3-none-any.whl (121 kB)
     |████████████████████████████████| 121 kB 67.0 MB/s 
Collecting zipp>=0.5
  Downloading zipp-3.19.1-py3-none-any.whl (9.0 kB)
Requirement already satisfied: pytz>=2015.7; python_version < "3.9" in /usr/lib/python3/dist-packages (from babel>=2.9->sphinx) (2019.3)
Collecting MarkupSafe>=2.0
  Downloading MarkupSafe-2.1.5-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (26 kB)
Requirement already satisfied: idna<4,>=2.5 in /usr/lib/python3/dist-packages (from requests>=2.25.0->sphinx) (2.8)
Requirement already satisfied: certifi>=2017.4.17 in /usr/lib/python3/dist-packages (from requests>=2.25.0->sphinx) (2019.11.28)
Requirement already satisfied: urllib3<3,>=1.21.1 in /usr/lib/python3/dist-packages (from requests>=2.25.0->sphinx) (1.25.8)
Collecting charset-normalizer<4,>=2
  Downloading charset_normalizer-3.3.2-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (141 kB)
     |████████████████████████████████| 141 kB 82.8 MB/s 
Installing collected packages: coverage, ruff, sphinxcontrib-serializinghtml, Pygments, docutils, packaging, zipp, importlib-metadata, sphinxcontrib-htmlhelp, sphinxcontrib-applehelp, babel, sphinxcontrib-jsmath, imagesize, sphinxcontrib-devhelp, alabaster, sphinxcontrib-qthelp, MarkupSafe, Jinja2, charset-normalizer, requests, snowballstemmer, sphinx, sphinxcontrib-jquery, sphinx-rtd-theme, isort
  WARNING: The scripts coverage, coverage-3.8 and coverage3 are installed in '/home/curt/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  WARNING: The script pygmentize is installed in '/home/curt/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  WARNING: The script docutils is installed in '/home/curt/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  WARNING: The script pybabel is installed in '/home/curt/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  WARNING: The script normalizer is installed in '/home/curt/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  WARNING: The scripts sphinx-apidoc, sphinx-autogen, sphinx-build and sphinx-quickstart are installed in '/home/curt/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  WARNING: The scripts isort and isort-identify-imports are installed in '/home/curt/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed Jinja2-3.1.4 MarkupSafe-2.1.5 Pygments-2.18.0 alabaster-0.7.13 babel-2.15.0 charset-normalizer-3.3.2 coverage-7.5.3 docutils-0.20.1 imagesize-1.4.1 importlib-metadata-7.1.0 isort-5.13.2 packaging-24.0 requests-2.32.3 ruff-0.4.7 snowballstemmer-2.2.0 sphinx-7.1.2 sphinx-rtd-theme-2.0.0 sphinxcontrib-applehelp-1.0.4 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-2.0.1 sphinxcontrib-jquery-4.1 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.5 zipp-3.19.1
curtcorum commented 1 month ago

As mentioned in #13 there seems to be missing dependencies in order to run tests using run_tests.ch which is not present.