search

jonboulle / clockwork

a fake clock for golang
Apache License 2.0
656 stars 57 forks source link

Timers #13

Closed aviddiviner closed 2 years ago

aviddiviner commented 7 years ago

Hey. Thanks for the excellent repo, I was looking for a time testing tool and this was a great start. Not sure if you're interested, but I've implemented timers on my fork.

The fake timers are quite closely inspired by the ones from the standard library and it should all work well. Your old After(d Duration) <-chan Time is now just a shortcut for my NewTimer(d).C (as it is in the standard lib), so I got test coverage from all your existing tests on the new timers too.

Let me know what you think and if you want me to modify anything. Cheers!

DPJacques commented 5 years ago

Hello,

I wanted to reach out and see if this pull request was still under review. I forked my own version of this repo and aviddiviner's to get the best-of-both-wrolds, but I'd love to see this repo support the timer work David has done.

Is there anything I can do to support this process? The repo I made to incorporate David's timer work is at https://github.com/DPJacques/clockwork. I can make a new pull request with no conflicts if that is helpful. Let me know.

sagikazarmark commented 2 years ago

Fixed in #38