search

jonboulle / clockwork

a fake clock for golang
Apache License 2.0
656 stars 58 forks source link

Expose and fix timer reset race #43

Closed gagern closed 1 year ago

gagern commented 2 years ago

Fixes https://github.com/jonboulle/clockwork/issues/42.

gagern commented 2 years ago

https://github.com/jonboulle/clockwork/pull/44 with its lock-holding approach might be better than the atomics here, because it gives stronger ordering guarantees and simplifies a number of other things, too.

sagikazarmark commented 1 year ago

If I understood correctly, #44 replaced this PR.

sagikazarmark commented 1 year ago

I believe this should be fixed. Feel free to reopen if it's not.