search

jonboulle / clockwork

a fake clock for golang
Apache License 2.0
656 stars 58 forks source link

Move most lock logic to clockwork.go. #50

Closed DPJacques closed 1 year ago

DPJacques commented 1 year ago

This uses longer timeouts throughout ticker_test.go to prevent flaky failures in slower runs.

It uses a timeout of 1 minute, which seems more than reasonable.

It also leaves the caller to execute multiple runs, if so desired.

DPJacques commented 1 year ago

Hmm, I tried to stack requests, but I seem to have screwed that up. My original request fixes #49. What I tried to do with the second request was consolidate some logic to make it easier for future contributors, but I think that is where my lack of familiarity with branches has gotten the best of me.

DPJacques commented 1 year ago

Closing this out to submit this larger effort in smaller, more manageable chunks.