Hi Jon,
Here is a pull request to address issues I was having with installing Rscattnlay from GitHub using:
devtools::install_github("jonbramble/RScattnlay")
I think mostly the problems I was having were version skew with roxygen2 (that's at least a guess). Most of the changes I made are in DESCRIPTION and NAMESPACE, however, NAMESPACE is now created using roxygen2 via devtools::document(). All of the roxygen2 directives were made into scattnlay.r. No changes were made to the functional code, so performance and accuracy is unchanged.
My workflow was as follows:
fork your RScattnlay repo into the rogerswt Github
make changes to DESCRIPTION, delete NAMESPACE
make roxygen2 directives in scattnlay.r
run devtools::document() to write NAMESPACE, Rd files
run CHECK, look for errors and warnings
push to rogerswt/RScattnlay
re-install via devtools::install_github("rogerswt/RScattnlay")
rinse and repeat
I also listed you as author and me as maintainer. Perfectly happy to change maintainer back to you.
Please note that I've never done a pull request, so I hope I've gotten this right!
My next job is to write the flowMie package to push this out to the flow cytometry extracellular vesicle community. Many thanks once again for Rscattnlay.
Hi Jon, Here is a pull request to address issues I was having with installing Rscattnlay from GitHub using:
devtools::install_github("jonbramble/RScattnlay")I think mostly the problems I was having were version skew with roxygen2 (that's at least a guess). Most of the changes I made are in DESCRIPTION and NAMESPACE, however, NAMESPACE is now created using roxygen2 via
devtools::document(). All of the roxygen2 directives were made intoscattnlay.r. No changes were made to the functional code, so performance and accuracy is unchanged.My workflow was as follows:
scattnlay.rdevtools::document()to write NAMESPACE, Rd filesdevtools::install_github("rogerswt/RScattnlay")I also listed you as author and me as maintainer. Perfectly happy to change maintainer back to you.
Please note that I've never done a pull request, so I hope I've gotten this right!
My next job is to write the
flowMiepackage to push this out to the flow cytometry extracellular vesicle community. Many thanks once again for Rscattnlay.Cheers, Wade