jonbrunt / ai-portfolio

Personal AI Engineering Portfolio Page
https://ai-portfolio-henna.vercel.app
MIT License
0 stars 0 forks source link

INTEGRATION TESTING #24

Closed jonbrunt closed 6 months ago

jonbrunt commented 6 months ago

Feature: Integration Tests

Description

This PR introduces integration testing for the site, as well as separating the execution of unit and integration tests depending on circumstance (push, PR, merge).

Changes

Frontend:

Testing

Notes

Checklist

Reviewers

Requesting review from @jonbrunt

Tags

#enhancement

jonbrunt commented 6 months ago
Screenshot 2024-03-18 at 1 50 22 PM

The integration tests are passing, but an error is being thrown regarding the window.scrollTo not being available in the Jest environment. I noticed this when reviewing the Actions log. We'll cover this functionality in subsequent e2e testing with Cypress, but can we mock the function to avoid this issue? It will save a bit of computing overhead. It is a detail, but it is key that we always try to reduce technical debt when feasible.

jonbrunt commented 6 months ago

Commit 478b327 solved the problem.

Will merge and delete the feature branch.