jonbrunt / ai-portfolio

Personal AI Engineering Portfolio Page
https://ai-portfolio-henna.vercel.app
MIT License
0 stars 0 forks source link

NAVBAR CREATES UNWANTED SPACE #3

Closed jonbrunt closed 7 months ago

jonbrunt commented 7 months ago

Issue Description

The Navbar is planned to always appear. The div where the conditional rendering occurs uses a min-h-screen Tailwind class. This creates extra space that can be scrolled and offsets the hero page content. This will occur on any page that has minimal content.

Steps to Reproduce

  1. npm run dev and open the localhost on any screen with any browser

Expected Behavior

The div should be distributed across the remaining space of the page, accounting for the Navbar

Actual Behavior

Extra space is created and offsets the Hero content, as narrated in the Description

Possible Solution

Remove the Tailwind min-h-screen class. Create a class in globals.css to calculate the min-height based on the vh - the height of the navbar (and set the height of the navbar to the 4rem that is currently its default daisyUI min-height). 2) Do the same with the height of the Navbar and experiment with using Tailwind's flex-1 class for the div, but this might not work/could get complicated. The first solution is probably the easiest albeit less consistent with Tailwind.

Tasks