jonbrunt / ai-portfolio

Personal AI Engineering Portfolio Page

https://ai-portfolio-henna.vercel.app

MIT License

0 stars 0 forks source link

ADD UNIT TESTS FOR HERO AND NAVBAR #7

Closed jonbrunt closed 7 months ago

jonbrunt commented 7 months ago

Feature:

Description

This PR introduces unit tests for the Hero and Navbar components, separating each component into a folder for the component and its test file.

Changes

Frontend:

Deleted tests dir
Added directories for each component and its test file
Added comprehensive unit tests for all conceivable and reasonable situations

Testing

Manual testing was conducted for each test
Unit tests pass in the terminal, and the site renders simultaneously in the dev server

Notes

Will iterate on these after integration and e2e testing is established
The automated pre-commit linting is functioning nicely (catching errors)

Checklist

[x] Code compiles correctly
[x] All tests passing
[x] No merge conflicts

Tags

#enhancement

jonbrunt commented 7 months ago

Looks good. There are some edge cases and situations difficult to test using RTL/Jest unit tests, but let's not use any time on that for now. Tests cover the basics well.

Will merge, and delete the feature branch. Let's move forward with the remaining components and unit tests, then establish integration and e2e testing, perhaps some snapshots. Then we'll add full functionality and overhaul the entire testing suite and CI/CD pipelines (to be established as well).