jonbrunt / ai-portfolio

Personal AI Engineering Portfolio Page

https://ai-portfolio-henna.vercel.app

MIT License

0 stars 0 forks source link

ABOUT COMPONENT #8

Closed jonbrunt closed 7 months ago

jonbrunt commented 7 months ago

Feature: About Component and Unit Tests

Description

This PR introduces the About component/view for the site. Comprehensive unit tests are included.

Changes

Frontend:

Added dir and files for About component and its unit test suite
Modified page.tsx to update conditional rendering

Testing

Manual testing was conducted in the dev server/browser
Unit tests all pass
Pre-commit linting passed
Integration tests will be added after frontend is completed

Notes

N/A

Checklist

[x] Code compiles correctly
[x] All tests passing
[x] No merge conflicts

Reviewers

Requesting review from @jonbrunt

Tags

#enhancement

jonbrunt commented 7 months ago

Looks good. Are these "renders" tests (always the first unit test of the suite) necessary? They seem to pass even when logical thinking says they shouldn't. We have enough protection in place that we don't need this test, but we can address this issue when we overhaul the testing with the CI/CD. For now, these are very sufficient.

Will merge, and delete the feature branch. Let's move forward with the Skills component.