search

joncage / ed-scout

An Elite Dangerous companion app to simplify finding unexplored worlds
MIT License
133 stars 18 forks source link

Attempt to improve stability a bit: #160

Closed alibabajevich closed 3 years ago

alibabajevich commented 3 years ago

tracebacks due to network issues appears quite often, after each process freezes

joncage commented 3 years ago

It's a decent start but I'm thinking..

  1. We ought to be raising proper exceptions rather than tuples (a bug from the original code I wrote).
  2. It would be cleaner to just detect and handle the issue without exceptions at all instead of using them for control as your current patch does.
  3. This whole section (not just your patch) could do with an overhaul. In particular, I think it would help to separate the EDSM lookups into a new pipeline so the display loads as quick as the game; Could have a spinny loading icon while the info is being gathered. Then as info comes in from EDSM, update the UI (or display an error indicating there's an EDSM connection issue).
alibabajevich commented 3 years ago

It's a decent start but I'm thinking..

  1. We ought to be raising proper exceptions rather than tuples (a bug from the original code I wrote).
  2. It would be cleaner to just detect and handle the issue without exceptions at all instead of using them for control as your current patch does.
  3. This whole section (not just your patch) could do with an overhaul. In particular, I think it would help to separate the EDSM lookups into a new pipeline so the display loads as quick as the game; Could have a spinny loading icon while the info is being gathered. Then as info comes in from EDSM, update the UI (or display an error indicating there's an EDSM connection issue).

Hi. This is awesome tool. Thank you for it. I'm just patched it for myself to be able to use it on my trip to Colonia :)

Bit disagree on 2, once you using requests lib that throws bunch of exceptions on quite usual network issues, probability of it for 500 jumps very close to 100%, and since it unprocessed, any of them will crush Flask thread. Pity but that make tool nearly unusable.

When you will make decision on some enhancements or redesign and need some help in coding. Let me know. I would like to help

o7

joncage commented 3 years ago

Made some updates based on your proposal: https://github.com/joncage/ed-scout/pull/167 ...just need to add some handling in the web interface to highlight there are EDSM link issues.