joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.65k stars 376 forks source link

DOS Navigator crashes with latest version (0.82.16) #1028

Open koszeggy opened 5 years ago

koszeggy commented 5 years ago

Describe the bug DOS Navigator crashes in DOSBox-X; however, it works in DOSBox 0.74, 0.74-2 and the MegaBuild version.

The real mode version does not work in any Windows build, DPMI version and Necromancer's DOS Navigator seems to be working in 32 bit versions but do crash in 64 bit Windows version.

To Reproduce

  1. Extract the uploaded dosnav.7z and mount the containing folder
  2. Execute either DOSNAV\DN, DOSNAV.DPM\DN or DOSNAV.NDN\NDN
  3. See error

Screenshots DOS Navigator 6.4.0 (both real mode and DPMI versions produce the same error) vs. DOSBox-X Windows x64 builds: dn_000

DOS Navigator 6.4.0 (real mode version) vs. DOSBox-X Windows x86 and MINGW builds: Please note that DOS Navigator silently crashed and the command prompt appeared after dn's prompt. Launch it again and it hangs up completely. command_000

Necromancer's DOS Navigator 2.31.5309 vs. DOSBox-X Windows x64 builds: ndn_000

Note: DPMI version and NDN seems to be working with Windows x86 and MINGW builds.

Environment:

joncampbell123 commented 5 years ago

If you can compile the source, pull the latest commit. Some fixes have been made for dynamic core (also to fix another issue tracker item regarding Quake).

koszeggy commented 5 years ago

Thank you for the fix. I cannot do a compile due to the missing C++ components from my VS installation so I can check it in the next release.

joncampbell123 commented 5 years ago

I want to clarify I think the latest commit fixes it. It does fix another issue reported with Quake and dynamic core though.

joncampbell123 commented 5 years ago

@koszeggy The latest release is available.

koszeggy commented 5 years ago

@joncampbell123: Today I checked it again and the issues are still the same with the Windows x64 version. The mingw-win64 build is somewhat different than before: with that the Dos Navigator Real version freezes in a strange way: the mouse cursor is moving but neither mouse clicks, nor the keystrokes are working.

scrutinizer80 commented 2 years ago

It crashes here using the SDL2 based 0.83.18 (Win/x64) with "Normal" core.

scrutinizer80 commented 2 years ago

DOS Navigator still crashes using the Open Source version from http://www.dnosp.com/e_index.php and DosBox-X 0.83.23.

It works as it should on DOSBox 0.74-3

grapeli commented 2 years ago

How can it be reproduce? It works for me.

https://user-images.githubusercontent.com/452325/159694364-a0931b1d-2150-4722-b513-d3650abe5132.mp4

https://user-images.githubusercontent.com/452325/159694387-de93c0a7-4849-4bdb-882d-9ae3bfd42be1.mp4

This bug report should have closed some time ago.

scrutinizer80 commented 2 years ago

It consistently fails as seen in the first screenshot when using a "normal" cpu core with the fpu option set to "true" in the configuration. It launches fine on the same "normal" cpu core when fpu is set to "false".

rderooy commented 2 years ago

If it fails with fpu=true and works with fpu=false it may be that your using the Windows VisualStudio (VS) build? If so, try the MinGW build instead.

The VisualStudio build only has 64bit precision for the FPU emulation, which is a VisualStudio limitation. While the MinGW build has the full 80bit FPU precision.

scrutinizer80 commented 2 years ago

If it fails with fpu=true and works with fpu=false it may be that your using the Windows VisualStudio (VS) build? If so, try the MinGW build instead.

The VisualStudio build only has 64bit precision for the FPU emulation, which is a VisualStudio limitation. While the MinGW build has the full 80bit FPU precision.

I'm using the VisualStudio version, as I've stated previously. I'll try your suggestion. Thanks for the tip. :)

scrutinizer80 commented 2 years ago

Ok. As per rderooy's suggestion, I can confirm this happens only on the VisualStudio build. The MinGW build works well.

scrutinizer80 commented 2 years ago

Since the VisualStudio build causes at least one program to fail, should it even be included in the dosbox-x distribution at this point?

scrutinizer80 commented 6 months ago

This issue still exists in the latest version 2024.03.01 (Visual Studio/64bit). This version doesn't seem to include a 64bit MinGW version in the installer...