joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.82k stars 383 forks source link

DOSBox-X won't generate or read any config files #1658

Open Slider-Whistle opened 4 years ago

Slider-Whistle commented 4 years ago

Describe the bug DOSBox-X seems to be completely unable to read or write to any config file.

To Reproduce Steps to reproduce the behavior:

  1. Calling dosbox-x -printconf will return $HOME/.dosbox/dosbox-0.83.1.conf (forgive the slightly outdated version). However, editing said file won't make any changes to DOSBox-X's behaviour.
  2. Configuring DOSBox through its inbuilt interface will seem to do things, but no config file is written to and the program consequently forgets all changes on relaunching.
  3. "CONFIG.COM -all -wcd dosbox.conf" does not generate any files.

Environment (please complete the following information):

rderooy commented 4 years ago

@Slider-Whistle The latest dosbox-x version has had a few updates in this regard. The default location on Linux is now ~/.config/dosbox-x

$ dosbox-x -printconf
/home/robert/.config/dosbox-x/dosbox-x-0.83.3.conf

sorry for the high version number, I'm running a development build that I compiled myself.

2) I tried it just now, I changed SDL autolock to true, and made sure to use the save option (Configuration -> Save) before closing the Configuration Gui. And the config file was properly updated.

3) config.com has been fixed already such that at least config.com -all -wcd works properly.

Slider-Whistle commented 4 years ago

Never noticed the little menu at the top of the DosBox-X Configuration window, it was a huge help you brought that up. I know it's probably copying the look of Windows 3 or something there, but that's missing some major visibility cues.

I think it could probably be helped by adding little underlines under the first characters (whether you can actually press alt+C to open up "Configuration" or not), making the main body of the window white while the top part is gray, and most importantly, moving the "Save" option next to "Close", maybe labelled as "Apply" for just an extra bit of familiarity. Maybe I'm just blind though.

Selected "Save" through the configuration menu's menu labelled "Configuration" and it worked, just like you said. Thanks again for the help.

As for the config.com thing and the file -printconf points to, it sounds like both have already been addressed.

So if I want the config file to start being read on boot, I should try upgrading to the latest stable version? EDIT: Nevermind. -printconf is still pointing to the wrong area, but dosbox-x is indeed reading the file I saved from the GUI.

rderooy commented 4 years ago

@Slider-Whistle Please upgrade to the latest version if you can. It should fix some issues in this regard.

As to the SDL Configuration GUI look, I agree it has a "windows 3.x" kind of look and feel, and does not integrate at all with your desktop environment. On windows, instead it looks completely different and does have the windows look and feel. Not sure where this look comes from.

joncampbell123 commented 4 years ago

The configuration GUI was inherited from wherever Daum's fork got it. I rather like the Windows 3.x look so I maintain it that way. Since importing from Daum I've cleaned up the code, fixed a few bugs, added titlebar color changes to help you know which one has the focus, and added scrolling regions and scrollbars so that the help text and long list of settings don't spill off the screen and become inaccessible.

joncampbell123 commented 4 years ago

One request I have, is that if I use a relative path like ./dosbox.conf, that -wcd should write to the current directory.

Wengier commented 4 years ago

@joncampbell123 The -wcp option (not -wcd) is exactly for this purpose, e.g. "config -wcp ./test.conf"