search

joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.67k stars 379 forks source link

Reduce DC-Offset caused by the PC Speaker #1670

Open rderooy opened 4 years ago

rderooy commented 4 years ago

Is your feature request related to a problem? Please describe. Another one from dosbox-staging that was just merged, that may be of interest. https://github.com/dosbox-staging/dosbox-staging/pull/413

Wengier commented 4 years ago

Is there a test set that can (easily) verify if the patch has been correctly applied?

kcgen commented 4 years ago

I compared before and with this set of PC speaker-based games to confirm it's regression free: https://github.com/dosbox-staging/dosbox-staging/pull/413#issuecomment-637255303

(And Sopwith, when @rderooy suggested it).

Then I checked non-PC speaker games (SB/GUS/Adlib) that hit the PC speaker for some reason on startup to confirm the DC offset is now quickly being fadded down before it has a chance to impact the mixer (and the other channels). Jungle Strike is a good example.

I posted the before and after recordings in the PR.. but yeah, did take a while to step through them.

Wengier commented 4 years ago

@kcgen I am glad to see that you are the author of this patch, so you know what you are doing. With the goal of being a complete DOS emulation package, DOSBox-X always welcomes improvements like this. So if possible, could you please add this patch to DOSBox-X too? Thank you very much for your work!

kcgen commented 4 years ago

Hi @Wengier ; thanks for the generous invitation to help DOSBox-X - unfortunately I have little time to put beyond what I'm contributing to dosbox-staging. That said, I'm happy to follow your progress here and add comments when I think I can provide value. Likewise, I'm sure our projects will continue to bear fruit for eachother like we've seen recently. Cheers :beers: