search

joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.68k stars 380 forks source link

Remove deprecated ways of compiling DOSBox-X on platform X, Y or Z. #1898

Open aybe opened 3 years ago

aybe commented 3 years ago

Describe the bug

Following #1863, #1191, some bits are misleading for compiling the project, namely:

Describe the solution you'd like

Jookia commented 3 years ago

I've opened #1900 and #1899 for this.

aybe commented 3 years ago

Okay, you've been faster than me, I was going to push the same!

🥇

aybe commented 3 years ago

@aybe when #1899 is merged, close this

Jookia commented 3 years ago

I've been over the past day or so trying to set up a build environment for Windows. There's currently this many build systems:

It would really be nice to drop the makefiles and the vs2013 project eventually as they seem to be prone to bitrot. The only person using these seems to be @yksoft1 and they're not being maintained.

andres-asm commented 3 years ago

What are you gonna be using in the future? please week mingw buildfiles supported

Jookia commented 3 years ago

What do you mean mingw buildfiles? Right now I think autoconf is used for builds?

andres-asm commented 3 years ago

Makefiles, sorry. I use MSYS2/MingW and I build dosbox, and X with autotools/make

Jookia commented 3 years ago

Are you using the makefiles in ref-static-makfiles? This wouldn't affect autotools or the ./build-mingw-* scripts

On Sun, Oct 04, 2020 at 09:28:41AM -0700, Andrés wrote:

Makefiles, sorry. I use MSYS2/MingW and I build dosbox, and X with autotools/make

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/joncampbell123/dosbox-x/issues/1898#issuecomment-703280337

aybe commented 3 years ago

To sum it up, vs2013 and nmake makefiles can be removed safely, correct ?

joncampbell123 commented 3 years ago

@yksoft1 I will approve of the removal of those files if you do not respond by Saturday October 10th.

Jookia commented 3 years ago

Yes, I think vs2013, nmake and mingw makefiles can be removed safely.

yksoft1 commented 3 years ago

I've been over the past day or so trying to set up a build environment for Windows. There's currently this many build systems:

  • vs2013 (broken)
  • vs2015
  • nmake makefiles
  • mingw makefiles
  • autotools

It would really be nice to drop the makefiles and the vs2013 project eventually as they seem to be prone to bitrot. The only person using these seems to be @yksoft1 and they're not being maintained.

As long as the nmake makefiles are fixed now, VS2013 solution is not needed at least for the master branch anymore.

Jookia commented 3 years ago

Can the mingw makefiles be ditched?

On Wed, Oct 07, 2020 at 11:08:15PM -0700, yksoft1 wrote:

I've been over the past day or so trying to set up a build environment for Windows. There's currently this many build systems:

  • vs2013 (broken)
  • vs2015
  • nmake makefiles
  • mingw makefiles
  • autotools

It would really be nice to drop the makefiles and the vs2013 project eventually as they seem to be prone to bitrot. The only person using these seems to be @yksoft1 and they're not being maintained.

As long as the nmake makefiles are fixed now, VS2013 solution is not needed at least for the master branch anymore.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/joncampbell123/dosbox-x/issues/1898#issuecomment-705352068