joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.66k stars 378 forks source link

Feature request: Support Chorus/Reverb for Adlib (like Sound Blaster AWE64 Gold) #2080

Open Dwedit opened 3 years ago

Dwedit commented 3 years ago

I remember when I got my Sound Blaster AWE64 Gold, then played a few DOS games. This was in the days of Windows 95/98, and you could still boot to DOS mode to play MS-DOS games.

The sound card had a feature where it could add Chorus/Reverb effects to the Adlib sound, and it really made the music come alive. It almost sounded like wavetable synthesis, but was still the same Adlib sound.

I don't still have that old computer anymore, and don't still have an example of exactly what it sounded like.

Edit: Here's a Youtube video demonstrating this feature: https://www.youtube.com/watch?v=6oSnhqMsmWM

Dwedit commented 3 years ago

I briefly checked for open source projects that have Chorus and Reverb effects, and there's ZynAddSubFX (GPL2) and GNUitar (GPL2). But I haven't listened to their effects, and don't know if they sound close enough to what the sound card does.

Dwedit commented 1 year ago

This feature was implemented in Dosbox Staging. https://github.com/dosbox-staging/dosbox-staging

Torinde commented 1 year ago

https://dosbox-staging.github.io/v0-79-0/#AudioImprovements - not sure which of those are relevant for DOSbox-X, e.g. some may already be implemented 3.1. AdLib Gold Surround Module Emulation 3.2. Sound Card Output Filter Emulation 3.3. Crossfeed 3.4. Reverb and Chorus 3.5. Master Compressor 3.6. General Mixer Improvements 3.7. "One OPL mode to rule them all" 💍 3.8. FluidSynth Configuration Changes 3.9. ripa's PC speaker Patch - #1722 3.10. Parallel Port DAC Models: Disney, Covox, and Stereo-On-1 - Disney/Covox already supported (although in Staging there are different from each other), what about Stereo-On-1? 3.11. Audio Mute and Pause - that seems supported already