search

joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.56k stars 373 forks source link

Show Ctrl, Shift, etc., instead of Mod1, Mod2, etc. in Mapper editor? #2745

Open emendelson opened 2 years ago

emendelson commented 2 years ago

The DOSBox-X menu system displays the correct names for the modifier keys (Ctrl, Option, etc.), but the Mapper editor only shows Mod1, Mod2, and Mod3. Experts can figure out what key Mod1 represents, but it would be a lot easier for everyone if the editor showed the actual names in the same way the menus show them.

Wengier commented 2 years ago

@emendelson The problem is that mods like Mod1, Mod2, Mod3 are not fixed, but they are bound to certain keys and are subject to be changed in this interface, and the bound keys are displayed in "BIND:". It may be possible to make the bound text more clear, but I don't think it is a good idea to change the buttons themselves.

emendelson commented 2 years ago

@Wengier - I understand this, thank you. But if the menu system can display the current state of the keys, perhaps the mapper interface could be updated when the key-bindings change? I realize this is asking a lot, but I hope it could be considered for a future version.

Wengier commented 2 years ago

There are both "Mod1", "Mod2", "Mod3", and "mod1", "mod2", and "mod3". The former are labels for actually assigning modifiers, and the latter are for using in other key combinations. I think the latter may be changed somehow to show the actual keys when clicked. The 0.83.16 version is currently being released.