Closed RobertJSawyer closed 3 years ago
Looks like a bug (only) in the last version (0.83.18) of DOSBox-X. The previous version (0.83.17) of DOSBox-X did not have this issue. Doing a git bisect
shows that this is the first commit having this issue: https://github.com/joncampbell123/dosbox-x/commit/9a00b9f0e7c4b62163077e40c55ba6f219a3eb93 ("Fix to open devices added by device.com to allow IOCTL and other operations"). @nanshiki probably wants to take a look at this, since it is related to the IOCTL device driver fix.
@RobertJSawyer @Wengier
@nanshiki It appears to fix the said problem. @RobertJSawyer can also try the latest build with the fix applied:
You guys are the best! Thank you! Quick testing with the updated DOSBox-X shows the problem to be gone. THANK YOU AGAIN!
Rob in Toronto
@RobertJSawyer can you please close this issue since it is resolved?
@viki-t-s: Before that PR is merged this issue shouldn't be closed (also why i can't quote comments???)
That PR is already merged, so closing.
Code of Conduct & Contributing Guidelines
Have you checked that no other similar bug report(s) already exists?
What operating system(s) this bug have occurred on?
Windows 7 32-bit SP1
What version(s) of DOSBox-X have this bug?
0.83.18 both SDL1 and SDL2 32-bit
Describe the bug
DOSBox-X has trouble with WordStar for DOS 7.0 macros that access the file system to overwrite or delete existing files.
The attached macro SAMPLE.WSM copies DOSBox-X's README.TXT from DOSBox-X's drive Z: to a file named TESTFILE.TXT in the current folder, and then copies TESTFILE.TXT five times to files named COPY1.WS, COPY2.WS, COPY3.WS, COPY4.WS, and COPY5.WS.
I've provided error handling in the macro to deal with prompts to confirm overwriting or for files not found, so that it should run successfully regardless of whether TESTFILE.TXT or COPY?.WS already exist.
Furthermore, the macro sets WordStar to help level 0 while it is running, which turns off all confirmations, so the error handling is actually redundant. The macro should simply run to completion with no prompting for confirmations by the user, no matter how many times the macro is invoked.
If you run the attached macro SAMPLE.WSM from WordStar's OPENING MENU (by selecting MP, for Macro Play), it succeeds the FIRST time, when none of the files it tries to overwrite already exist.
But if you run it a SECOND (or subsequent time), it will crap out, first by asking the user for confirmations that should not be required, and, second, by dropping parts of commands.
The macro runs flawlessly under vDosPlus by @Wengier as well as TameDOS, but fails under DOSBox-X.
Expected behavior
WordStar should be able to overwrite or delete existing files using its own file-copy or file-delete commands from within a macro.
Steps to reproduce the behaviour
Used configuration
Emulator log
No response
Additional context
No response