joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.79k stars 382 forks source link

-set "scaler=xxxx forced" has a bug and doesnt diplay the orginal resolution #3165

Open curvedlinee opened 2 years ago

curvedlinee commented 2 years ago

Code of Conduct & Contributing Guidelines

Have you checked that no other similar bug report(s) already exists?

What operating system(s) this bug have occurred on?

win8

What version(s) of DOSBox-X have this bug?

0.83.21

Describe the bug

IF /I %VAR3%==1 SET WW=scaler=normal2x IF /I %VAR3%==2 SET WW=scaler=normal3x IF /I %VAR3%==3 SET WW=scaler=advinterp2x IF /I %VAR3%==4 SET WW=scaler=advmame2x IF /I %VAR3%==5 SET WW=scaler=hq2x SET W1=%WW%

SET W2=windowresolution=original

SET P1= -conf "dosbox-x.conf" -set %W2% -set %W1%

SET P2= -conf "dosbox-x.conf" -set %W2% -set "%W1% forced"

case P1: it works for var3==1, 2, 3, 4 or 5 and has no problems, all worked as intended

case P2: when var3==2 it displays out of proportion, it seemed like 2100x1600 or something. when var3 is 1, 3, 4 or 5, they dont display at the original resolution, they all display at 1 fixed resolution maybe about 1000x1000

-set "%W1% forced" worked fine with numbered resolution like 1024x768

Expected behavior

No response

Steps to reproduce the behaviour

see above

Used configuration

No response

Emulator log

No response

Additional context

No response

Wengier commented 2 years ago

If a scaler cannot be auto-applied unless forced, then it means it may not be designed for your environment. You can force to apply it, but it may not always work properly in this case. You can try another scaler which can be applied without forcing it.

curvedlinee commented 2 years ago

how come any scalers work well with doxbox? you can pay one more attention of these two settings windowresolution=original and scaler="normal3x" forced, despite my OS environment. the same thing happened in my win10. scaler may not be important to consider much in box-x, since it may not be for games.

Wengier commented 2 years ago

I think it may be due to the DPI setting in case your Windows is set to high DPI. Perhaps you can try set "dpi aware=true" in [dosbox] section and see if it works. On the other hand, DOSBox does not support DPI awareness so it does not have such an option.

Meanwhile, it may be true to some degree that scalers are less important in DOSBox-X than in DOSBox since scalers are less important for non-games, but it is always better to support them as possible.