search

joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.65k stars 376 forks source link

PCJr music sounds bad on Jumpman (booter version) #3329

Open Jkapp76 opened 2 years ago

Jkapp76 commented 2 years ago

Code of Conduct & Contributing Guidelines

Have you checked that no other similar bug report(s) already exists?

What operating system(s) this bug have occurred on?

windows 11

What version(s) of DOSBox-X have this bug?

0.83.23 (and older)

Describe the bug

The intro music and various end-level tunes on jumpman (booter version) have a high-pitched shrill tone that plays over it. This does not happen on real hardware or the 86box emulator.

Expected behavior

Clean, perfect music.

Steps to reproduce the behaviour

Load the game and listen to the intro music in PCJr mode. The distortion sounds a bit different each time, it's not a consistant sound.

Used configuration

pcjr mode
rderooy commented 2 years ago

I'm guessing this is the same issue you reported against -staging? https://github.com/dosbox-staging/dosbox-staging/issues/1542

Jkapp76 commented 2 years ago

Yes. This is the same issue. The guys from staging sent me a work-in-progress exe in January that fixed the issue, but I guess it's not ready for prime-time?

Jkapp76 commented 2 years ago

I tried all of the tandyrate outputs, (44100, 48000, 32000, 22050, 16000, 11025, 8000, 49716) and they all sound the same. only the pitch of the unwanted distortion seems to change with each setting. The lower outputs make the distortion lower etc.

I believe staging fixed the issue with "96000 Hz output without resampling". This seems to me that it would at least place the pitch of the distortion outside of our ability to hear it. (it sounded great)