Put main banner ANSI in an .ANS file and allow us to do random upon opening of DosBox-X

Docwiz2 commented 2 years ago

Code of Conduct & Contributing Guidelines

[X] I agree to follow the code of conduct and the contributing guidelines.

Have you checked that no other similar feature request(s) already exists?

[X] I have searched and didn't find any similar issues.

Is your feature request related to a problem? Please describe.

No response

What you want

The main banner is in the .exe executable, take it out and put it in a file such as banner1.ans

Allow the creation of more banners to be picked at random if the option is turned on in the config file. Create banner1.ans, banner2.ans, banner3.ans, banner4.ans

DEFAULT BEHAVIOR SHOULD BE banner1.ans to display the normal banner

Describe alternatives you've considered

No response

Additional context

No response

arrowgent commented 2 years ago

well they could leave default banner1.ans in the .exe just write a runtime flag dosbox-x -banner and config option to use external files...

i know it seems like an important feature but i think this is a very small use-case example most people dont care about the banner or randomizing at launch more importantly they run dosbox and get into the software/game they intended

you could always fork; externalize banner1.ans and write some code to allow randomizing external files that would make it quite easy for you to keep things updated to the upstream repo but i dont see any priority for dosbox-x to enhance this feature especially when youre asking them to "remove the banner displaying our logo"

Docwiz2 commented 2 years ago

I understand, but when I am coding I never have anything hard coded as much as possible.

It's better coding practice to not have anything you really don't need to be hard-coded being in there and it makes things flexible. Not everyone can compile their own executables and it allows the flexibility to work much better.

On Sat, Apr 2, 2022 at 11:27 AM arrowgent @.***> wrote:

well they could leave default banner1.ans in the .exe just write a runtime flag dosbox-x -banner and config option to use external files...

i know it seems like an important feature but i think this is a very small use-case example most people dont care about the banner or randomizing at launch more importantly they run dosbox and get into the software/game they intended

you could always fork; externalize banner1.ans and write some code to allow randomizing external files that would make it quite easy for you to keep things updated to the upstream repo but i dont see any priority for dosbox-x to enhance this feature especially when youre asking them to "remove the banner displaying our logo"

— Reply to this email directly, view it on GitHub https://github.com/joncampbell123/dosbox-x/issues/3379#issuecomment-1086697002, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYQV6JDDBC7PLTHOT6Z2ZU3VDCGRFANCNFSM5SKTKHZQ . You are receiving this because you authored the thread.Message ID: @.***>

joncampbell123 / dosbox-x