joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.82k stars 383 forks source link

App stops screensaver from activiating on MacOS #4243

Open palmerj opened 1 year ago

palmerj commented 1 year ago

Describe the bug

On MacOS the app stops the OS from running it's screensaver. Please implement something like this in dosbox-x to remove this limitation https://github.com/dosbox-staging/dosbox-staging/pull/717/files

Workaround for now is to run dosbox-x with SDL_VIDEO_ALLOW_SCREENSAVER=1 /Applications/dosbox-x.app/Contents/MacOS/dosbox-x &

Steps to reproduce the behaviour

  1. Ensure screensaver is set to run in MacOS settings
  2. Run dosbox-x
  3. Check activity monitor and check dosbox-x process in energy tab. It reports Preventing Sleep as Yes

Expected behavior

Screensaver should work when running dosbox-x.

What operating system(s) this bug have occurred on?

MacOS 13.1

What version(s) of DOSBox-X have this bug?

DOSBox-X 2023.03.31

Used configuration

No response

Output log

No response

Additional information

No response

Have you checked that no similar bug report(s) exist?

Code of Conduct & Contributing Guidelines

joncampbell123 commented 1 year ago

Good idea. Knowing the SDL library it made sense for them to do that, but yes, perhaps let's give the option to allow screensaver.