search

joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.82k stars 383 forks source link

Periodic slowdown in Norton Commander when menu bar clock is enabled #4280

Closed pppq closed 1 year ago

pppq commented 1 year ago

Describe the bug

I just updated my installation from 2022-12-26 to 2023-05-01 (both were of the VS-SDL2-x64-Windows kind) and encountered a curious issue with the new release: if I enable the display of the menu bar clock in Norton Commander 5.0, screen updates come to a complete stop whenever the : separator appears or disappears. CPU usage does not jump up while this happens.

I tried to disable the lazy/on demand rendering per the instructions in the changelog and #4214 but it doesn't seem to affect this behaviour.

The issue is not present in the build artifact for commit https://github.com/joncampbell123/dosbox-x/commit/f2f4a10844c48eeaf2da4a8c55f5b89d767d9d3a.

Steps to reproduce the behaviour

  1. Launch NC.EXE in the emulated instance
  2. Select Commands > Configuration > Screen
  3. Disable the menu bar clock
  4. Navigate to a directory with a lot of files; press and hold the ↓ key; observe that the selection moves continuously down the list without any abrupt breaks
  5. Enable the menu bar clock via the preference panel mentioned in step 2)
  6. Try to move through the files list again; observe that the selection stops being updated approximately every second, and the hour-minutes separator character in the clock is blinking with the same time interval. When things get going again, the selection flies through multiple rows very quickly, then carries on moving at the regular pace.

Expected behavior

No response

What operating system(s) this bug have occurred on?

Windows 10 22H2 64-bit

What version(s) of DOSBox-X have this bug?

2023-05-01 VS (tested both SDL and SDL2) x64

Used configuration

No response

Output log

No response

Additional information

No response

Have you checked that no similar bug report(s) exist?

Code of Conduct & Contributing Guidelines

maron2000 commented 1 year ago

If you are using the release version, try the latest development build.

pppq commented 1 year ago

That did work. I mentioned this in the report above:

The issue is not present in the build artifact for commit https://github.com/joncampbell123/dosbox-x/commit/f2f4a10844c48eeaf2da4a8c55f5b89d767d9d3a.

pppq commented 1 year ago

This issue seems to be resolved with the 2023-09-02 / VS / SDL2 / x64 release build.