Non-categorized fixes and improvements. Most of the fixes are for compile warnings, small code improvements. The most outstanding largest change is 39906a9399324f6d9503ae17f52564811af4a355 which makes use of the override specifier for overriding virtual methods and sets -Wsuggest-override. Commit 8f58674c5b2b80cca15035d814133726d6727557 also sets -Wnon-virtual-dtor.
What issue(s) does this PR address?
None I know of on GitHub.
Does this PR introduce new feature(s)?
No.
Does this PR introduce any breaking change(s)?
Not that I know of.
Additional information
Feel free to rebase, merge, cherry-pick or discard any of these changes.
I will likely continue to work on the codebase for at least some months in my spare time, but I'm doing so in hopes to eventually help some users run a legacy DOS software. So on one hand I will probably end up with a lot of commits which good to pull, but on the other hand I also see the possibility that I might not have enough time to polish all my changes into pull requests and lobby them to be merged. Due to time constraints I'm in a difficult position where I might have to prioritize development in my personal fork, making cardinal changes which might make later merges more difficult (e.g. breaking apart the long files into more modular translation units, switching to CMake or newer versions of C++ etc).
Either way, even thou I want to help it might not be a good thing for me to continuously bother You by filing new pull requests I don't have much time to focus on. I'm wondering what would be best way forward for this to be mutually beneficial and I'd appreciate Your comment on this. Also, I apologize if all this makes me a difficult person to deal with.
Non-categorized fixes and improvements. Most of the fixes are for compile warnings, small code improvements. The most outstanding largest change is 39906a9399324f6d9503ae17f52564811af4a355 which makes use of the override specifier for overriding virtual methods and sets
-Wsuggest-override. Commit 8f58674c5b2b80cca15035d814133726d6727557 also sets-Wnon-virtual-dtor.What issue(s) does this PR address?
None I know of on GitHub.
Does this PR introduce new feature(s)?
No.
Does this PR introduce any breaking change(s)?
Not that I know of.
Additional information
Feel free to rebase, merge, cherry-pick or discard any of these changes.
I will likely continue to work on the codebase for at least some months in my spare time, but I'm doing so in hopes to eventually help some users run a legacy DOS software. So on one hand I will probably end up with a lot of commits which good to pull, but on the other hand I also see the possibility that I might not have enough time to polish all my changes into pull requests and lobby them to be merged. Due to time constraints I'm in a difficult position where I might have to prioritize development in my personal fork, making cardinal changes which might make later merges more difficult (e.g. breaking apart the long files into more modular translation units, switching to CMake or newer versions of C++ etc).
Either way, even thou I want to help it might not be a good thing for me to continuously bother You by filing new pull requests I don't have much time to focus on. I'm wondering what would be best way forward for this to be mutually beneficial and I'd appreciate Your comment on this. Also, I apologize if all this makes me a difficult person to deal with.