joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.53k stars 371 forks source link

Current code builds non-working executable under macOS Monterey Intel #4993

Open emendelson opened 1 month ago

emendelson commented 1 month ago

Describe the bug

Current code (230b1e3) builds successfully on ARM macOS Monterey and Sonoma and Intel Sonoma. However, the build executable created under Intel Monterey doesn't run. The OS treats it as a text file. I've tried running chmod +x but (as expected) it has no effect. (I haven't tried with Ventura.)

This happens with both SDL1 and SDL2 builds.

Steps to reproduce the behaviour

Under macOS Monterey on Intel, run the two build macos- build scripts and try to launch the resulting executable. They open in TextEdit.

Expected behavior

The executable runs.

What operating system(s) this bug have occurred on?

macOS Monterey 12.7.4 (Intel)

What version(s) of DOSBox-X have this bug?

macOS build as of commit 230b1e3

Used configuration

No response

Output log

No response

Additional information

No response

Have you checked that no similar bug report(s) exist?

Code of Conduct & Contributing Guidelines

maron2000 commented 1 month ago

Built and working fine here on Intel Monterey 12.7.4, both SDL1 and SDL2. make dosbox-x.app works fine as well. It may be worth noting that the nightly Intel builds are currently built on latest Monterey (12.7.4 as of date of this post).

emendelson commented 1 month ago

@maron2000 - You're right. I hadn't run make dosbox-x.app. The executable alone won't launch on my setup, but the app runs exactly as it should. I wish I could understand why this is happening, but I can't...

maron2000 commented 1 month ago

It's really strange. ./build-macos -> src/dosbox-x works fine. Ventura worked fine as well.