This commit fixes most -Wzero-as-null-pointer-constant warnings, except in some places which appear to be vendored 3rd party libraries, e.g. in sdl_ttf.c, libchdr, physfs and gmock and in 3rd party components therein. Since it might make more sense to update this 3rd party code to some later versions instead of fixing the warnings manually, I decided not to enable the C++ compiler flag in configure.ac at this point.
In two functions with the return type of std::string executed return 0; statements, causing std::string to be constructed from a null pointer. To avoid undefined behavior these were changed to return {};.
This commit fixes most
-Wzero-as-null-pointer-constantwarnings, except in some places which appear to be vendored 3rd party libraries, e.g. insdl_ttf.c, libchdr, physfs and gmock and in 3rd party components therein. Since it might make more sense to update this 3rd party code to some later versions instead of fixing the warnings manually, I decided not to enable the C++ compiler flag inconfigure.acat this point.In two functions with the return type of std::string executed
return 0;statements, causingstd::stringto be constructed from a null pointer. To avoid undefined behavior these were changed toreturn {};.