Add build instructions for Raspberry PI

joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project

GNU General Public License v2.0

2.53k stars 369 forks source link

Add build instructions for Raspberry PI #5048

Closed maron2000 closed 1 week ago

maron2000 commented 1 week ago

Add build instructions for Raspberry PI, which is proven to work by the official Raspberry PI website.

Torinde commented 1 week ago

Why dropping Vista installer support when adding those Pi instructions, how are those related? Or it's just a coincidence in time?

Is it really needed to drop Vista from the regular installers (I assume that doesn't affect the XP installers)?

maron2000 commented 1 week ago

It's due to security reason that we cannot build it. See the build error.

joncampbell123 commented 1 week ago

Why dropping Vista installer support when adding those Pi instructions, how are those related? Or it's just a coincidence in time?

Is it really needed to drop Vista from the regular installers (I assume that doesn't affect the XP installers)?

I agree. If your pull is about build instructions for the Raspberry Pi, then it should only add build instructions for the Raspberry Pi. Drop the Windows installer commit and I'll merge the Pi instructions.

Torinde commented 1 week ago

For the first commit I see:

I'll try the XP installer in Vista, to confirm it works there, just in case that's the only way forward.

maron2000 commented 1 week ago

As per your request, I reverted the commit. Sorry for the confusion.

Torinde commented 1 week ago

Action failed again in the Windows installer. If removing Vista support is the only option - I just tested the XP installer - it works in Vista x86/x64. I also tested standard (non XP) VS builds - win32 works in Vista x86, win64 works in Vista x64.

So, I suggest keeping the second commit (maron2000, to revert the revert, sorry!) and adjusting INSTALL.md accordingly:

Windows 9x/NT4/2000 users should use the MinGW lowend 9x builds (32-bit SDL1 only).
Windows XP users.... [rearranging, so that 9x is first and Win7/modern is last]
Windows Vista users can use the XP installer or standard (non-XP) Visual Studio builds, because standard (non-XP) installer doesn't work in Vista. MinGW dropped support for XP/Vista, so install the 32-bit low-end builds from the XP compatible installer if you prefer MinGW builds.

Website also would have to be updated - after the next release when there is a release Windows installer.

maron2000 commented 1 week ago

@Torinde Let's close this PR by just adding the build instructions for Raspberry PI, as @joncampbell123 requested not to mix several fixes in a single PR. The website should be updated not now but after the next release.