search

joncampbell123 / dosbox-x

DOSBox-X fork of the DOSBox project
GNU General Public License v2.0
2.78k stars 382 forks source link

Check: Wsign-conversion fixups vs OPL2/OPL3 and Tandy 3-voice emulation #751

Open joncampbell123 opened 6 years ago

joncampbell123 commented 6 years ago

Additional testing is needed to check whether the typecast fixups broke or changed the behavior of the OPL3 emulation (dbopl.cpp) and Tandy 3-voice emulation (tandy_sound.cpp).

The breakage may be subtle and hard to discern without explicit A vs B comparison.

I do not hear any differences so far. I am concerned however there may be inaudible breakage, despite how carefully and delicately the typecast fixes were applied.

joncampbell123 commented 6 years ago

Also check: 3Dfx Voodoo emulation