search

jonchurch / tradingview-js-api-tutorial

308 stars 181 forks source link

tradingview-js-api-tutorial Integration #4

Closed milesmiles902 closed 6 years ago

milesmiles902 commented 6 years ago

Would you be willing to help me out on this? https://github.com/tradingview/charting_library/issues/3388

milesmiles902 commented 6 years ago

Jon,

Please help. I'm noob.

_Miles

milesmiles902 commented 6 years ago

In reality, all the JS should work the same without React and I have an HTTPS server already running on the VPS. Shouldn't I just be able to refer to the correct index.html and npm run build?

I'm noob.

jonchurch commented 6 years ago

Hey there, react isnt a webserver. You would run npm build and then host the resulting bundle and index.html.

Im not sure what your actual issue is, but if you have a question about the tutorial Im happy to help you. On Wed, Sep 26, 2018 at 4:12 AM milesmiles902 notifications@github.com wrote:

In reality, all the JS should work the same without React and I have an HTTPS server already running on the VPS. Shouldn't I just be able to refer to the correct index.html and npm run build?

I'm noob.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jonchurch/tradingview-js-api-tutorial/issues/4#issuecomment-424503044, or mute the thread https://github.com/notifications/unsubscribe-auth/AMUR2xpbz26NvyGOmxCIN-30XEMzQ7wmks5uepwhgaJpZM4Wyffc .

milesmiles902 commented 6 years ago

Thanks so much Jon! I am only partial noob now because I will make my question clearer.

If i want to host the resulting /build folder on a web server, such as digital ocean or heroku. I would need to migrate https://github.com/milesmiles902/Build over to the server and reference the index.html with an npm express or serve client, .htaccess etc? I just want to be able to see it within the browser without the local testing environment and am unsure on the process.

milesmiles902 commented 6 years ago

I'll post a mini-guide when I figure it out.

milesmiles902 commented 6 years ago

Fixed npm run build Put in server root as mentioned by Jon.

Although, I'm still noob.