joncodo / Crib

A crib engine to play the card game crib with AI and a card counter
3 stars 2 forks source link

card_spec.rb code review #6

Closed scott-steadman closed 10 years ago

scott-steadman commented 10 years ago

I would get rid of the before(:each) block and just create the cards as needed. Because you're creating cards you aren't using in your tests.

I think describe Card, '#value' can be describe '#value' since it's already within the describe Card block.

Change the spec-name 'is has the number value...' to 'is the rank value...'