Add timeout when setting cursor position on android devices

jondavidjohn / payform

:credit_card: A library for building credit card forms, validating inputs, and formatting numbers.

https://jondavidjohn.github.io/payform/

Other

427 stars 81 forks source link

Add timeout when setting cursor position on android devices #26

Closed drei01 closed 7 years ago

drei01 commented 7 years ago

Per https://github.com/text-mask/text-mask/pull/400/files

drei01 commented 7 years ago

Fixes https://github.com/jondavidjohn/payform/issues/21

jondavidjohn commented 7 years ago

Thanks @drei01!

@stuyam Do you have a way to confirm this indeed fixes #21 ?

stuyam commented 7 years ago

I will give it a try and get back to you on if this fixes it ASAP! Thanks for the contribution @drei01

drei01 commented 7 years ago

The only way I was able to confirm this fixes the issue was my own testing on an Android device. It would be good if @stuyam could also confirm.

stuyam commented 7 years ago

Seems like the fix hasn't changed the bug. Take a look. This is on Nexus 4 running Android 5.1.1 on chrome 57.

payform-bug

stuyam commented 7 years ago

@drei01 your changes in your repo definitely make sense to me. However I tested on a few android devices and now all of the numbers are entering exactly backwards. The caret stays at the front of the text input and all the text trails in reverse at the end of the input.