Add documentation for credit and debit card IIN patterns

ddayguerrero commented 5 years ago

Changes

I created a document that showcases all card types supported by Payform. It includes the IIN/BIN pattern and the general card length of each provider. Most importantly, I added sources to add credibility on our regex patterns.
As I was researching for BIN databases, I learned that it is really difficult to find official documentation. According to ISO, all IIN numbers are issued by a single entity called the American Bankers Association. They have official whitepapers however they are costly. Also, this doesn't cover some of the international card providers used in Payform. I tried my best to obtain credible references (e.g. payment processors, payment providers, e-commerce UX firms) and I made sure that the updated patterns are valid.

Suggestions

While we could have an external markdown file, I believe it would be better to create a GitHub wiki as users may miss this interesting piece of documentation! 😎

OR

We can replace current Supported card types: section in the README.md

Let me know what you think!

cc @jondavidjohn

Sneak peek

cardrules

jondavidjohn commented 5 years ago

@ddayguerrero Thanks for doing all this legwork, I'm fine with a wiki, that way we can add references w/o cutting new versions as they come up. I've enabled the wiki for this repo. Let me know if you need anything else to get this content in there. Might be worth linking to from the README though.

ddayguerrero commented 5 years ago

My pleasure! 😄 I'm fine with adding both. We can add this piece of documentation to the Wiki and also link it in the README.

I recently amended my commit to fix typos and all card types are present. I also submitted another fix that improves deletion of the credit card string!

ddayguerrero commented 5 years ago

It looks better with those tricks! Thanks!

jondavidjohn / payform