Widen support for Maestro BIN patterns - Githubissues

jondavidjohn / payform

:credit_card: A library for building credit card forms, validating inputs, and formatting numbers.

https://jondavidjohn.github.io/payform/

Other

427 stars 81 forks source link

Widen support for Maestro BIN patterns #54

Closed ddayguerrero closed 5 years ago

ddayguerrero commented 5 years ago

Fixes #53

Context

According to the issue, our latest BIN range for Maestro debit doesn't support the BINs found in the latest Mastercard Rules — June 2018

The Corporation may assign a Customer that engages in or is approved by the Corporation to engage in Activity one or more bank identification numbers (BINs).

The Corporation may assign BINs at its discretion from the following block ranges:

• Maestro: 639000 to 639099 and 670000 to 679999

Changes

I updated our regular expression so that it surfaces 639000 to 639099 and 670000 to 679999 BIN rages.
For the sake of we don't break anything, I kept the patterns that were excluded from the new ranges. I've also removed the numbers that are found within the ranged.

How is this achieved?

Old regex: /^(5018|5020|5038|6304|6703|6708|6759|676[1-3])/
New regex: /^(5018|5020|5038|6304|6390[0-9]{2}|67[0-9]{4})/
- Removed 6703, 6708, and 6759
- Kept 5018, 5020, and 5038
- Added ranges 639000 to 639099 and 670000 to 679999

ddayguerrero commented 5 years ago

Good call, we definitely can!