search

jondavidjohn / payform

:credit_card: A library for building credit card forms, validating inputs, and formatting numbers.
https://jondavidjohn.github.io/payform/
Other
427 stars 81 forks source link

#56 - DinersClub validation #59

Open frappacchio opened 5 years ago

frappacchio commented 5 years ago

Hi @ddayguerrero, i hope this is the right one :)

Thanks, Francesco

frappacchio commented 5 years ago

Hi @ddayguerrero i rebased it from your repo :)

ddayguerrero commented 5 years ago

Nice! Consider my latest comments please and we should be good! 😊

frappacchio commented 5 years ago

I've changed the regex for Dinersclub in order to include also the 39... cards as per Wikipedia rules https://en.wikipedia.org/wiki/Payment_card_number#Issuer_identification_number_(IIN)

ddayguerrero commented 5 years ago

Nice! We're only missing the changes mentioned in the comment then we're set!

frappacchio commented 5 years ago

Hi @ddayguerrero i've rebased from 1.4.0 release. Tell me if i can do more in order to merge my pull request. Thanks, Francesco