search

jondavidjohn / payform

:credit_card: A library for building credit card forms, validating inputs, and formatting numbers.
https://jondavidjohn.github.io/payform/
Other
427 stars 81 forks source link

Bugfix/63 caret moved to the end #64

Open andygi opened 5 years ago

andygi commented 5 years ago

Bugfix of #63 (Caret moved to the end of input after change). Fixed for LTR only and testable manually only, by index.html and jquery.html. In the ticket there a clear description of how to reproduce the issue and, consequently how to test it. I have created a jquery and javascript index RTL page in order to test RTL as well.

andygi commented 5 years ago

@ddayguerrero,

Do you mind un-staging all changes in the dist/ folder please?

Could you help me to better understand what do you need, please?

andygi commented 5 years ago

@ddayguerrero , I see, no problem I have reverted the code into dist directory and thank you for the explanation. To be bulletproof, if you want, I can add this directory into gitingore file as well. Let me know.

ddayguerrero commented 5 years ago

If you don't mind then that would be cool @andygi!

andygi commented 5 years ago

If you don't mind then that would be cool @andygi!

@ddayguerrero Sure, I have done!

jondavidjohn commented 5 years ago

Sorry, but we actually want to not ignore that directory, we need it for package managers (like bower) that require we commit the compiled files.

https://github.com/jondavidjohn/payform/blob/master/bower.json#L3

ddayguerrero commented 5 years ago

Right, I completely missed that @jondavidjohn! Thanks for 👀, we can undo that change @andygi

andygi commented 5 years ago

@ddayguerrero , no problem I have reverted the commit.