search

jondot / graphene

Graphene is a realtime dashboard & graphing toolkit based on D3 and Backbone.
http://jondot.github.com/graphene
2.87k stars 231 forks source link

Highlight toggle flips states when graph is updated #79

Open wndhydrnt opened 10 years ago

wndhydrnt commented 10 years ago

When hovering over the description of a graph, its line and area get highlighted by adding a specific CSS classes to these elements in DOM. When the pointer leaves the description, these classes are removed from the DOM.

If a graph is highlighted while being updated with the latest data, the toggle flips. Now the line and area of a graph are highlighted when the pointer leaves the description.

Such thing is unlikely to happen when a graph refreshes in long periods of time, but can be a problem if the graph updates itself every five seconds or so.

This pull request takes this edge case into account. I also did some formatting.

emarcotte commented 10 years ago

Been using this for a bit now, works pretty good.