search

jondot / sneakers

A fast background processing framework for Ruby and RabbitMQ
https://github.com/jondot/sneakers
MIT License
2.24k stars 333 forks source link

Possible wrong log level in reload_config! #400

Closed melvinsh closed 4 years ago

melvinsh commented 4 years ago

Every time I start my environment with log level WARN I get the following message from all of my workers:

WARN: Loading runner configuration...

This seems to be defined here: https://github.com/jondot/sneakers/blob/7c059d1490e4dde43f98b801c38e4e0df7ac458c/lib/sneakers/runner.rb#L43

Shouldn't this be Sneakers.logger.info as it is not an actionable warning?

melvinsh commented 4 years ago

@gabrieljoelc what do you think? I'd be happy to submit a PR.

gabrieljoelc commented 4 years ago

yes it should and yes please do! 🙏

melvinsh commented 4 years ago

Thanks @gabrieljoelc & @michaelklishin 😊👏