search

jondot / sneakers

A fast background processing framework for Ruby and RabbitMQ
https://github.com/jondot/sneakers
MIT License
2.24k stars 333 forks source link

Unlock Rack gem version #426

Closed morgoth closed 4 years ago

morgoth commented 4 years ago

I can see in https://github.com/jondot/sneakers/commit/591d2131b3b9d099e5b4401a0921335886ed9a2f that rack gem version was locked. There is already 13.x of rack gem which is not allowed by this restriction. Is there any reason to lock it or can it be relaxed?

rpbaltazar commented 4 years ago

Related to #422 I think that this can be closed then. What we would need is a new release.

bumi commented 4 years ago

The commit closing #422 seems to miss the development dependency: https://github.com/jondot/sneakers/commit/415f283f7e634601528105323d0dac9663c5786d

gem.add_development_dependency 'rake', '~> 12.3' why is it a development and runtime dependency?

rpbaltazar commented 4 years ago

The commit closing #422 seems to miss the development dependency: 415f283

gem.add_development_dependency 'rake', '~> 12.3' why is it a development and runtime dependency?

That's very nicely spotted. I have no clue why would it be on both dependencies...

mobilutz commented 4 years ago

Would like to know as well, why rake is restricted to < 13?