search

jondurrant / RPI-PicoW-WolfSSL-Exp

MIT License
7 stars 4 forks source link

Potential typo in TestTrans.cpp #1

Closed hptechdesign closed 1 year ago

hptechdesign commented 1 year ago

Hello, and thanks for the great video and supporting repo.

I'm in the early stages of working through these - I've cloned the repo and set up my environment variables. When I build, the WIFI_SSID variable is being set and declared but WIFI_PASSWORD is not.

I'm working through that issue, assuming it is something I've done. Incidentally - and presumably unrelated - I found what looks like an error.

In line 74 of TestTrans.cpp:

if (WifiHelper::join(WIFI_SSID, **WIFI_SSID**)){

Should it not be

if (WifiHelper::join(WIFI_SSID, **WIFI_PASSWORD**)){ ?

jondurrant commented 1 year ago

You are absolutely right. Apologies for letting this one slip in. It still worked for me as it is joining on line 111 of main.cpp.

Hope this fixes the issue. If not I have had some Wifi connectivity issues when the Pico-W is short of power in the past. Just in case your problem isn't really with credentials.

hptechdesign commented 1 year ago

That's a fast response - caused no issue for me yet since I'm still debugging compile errors in main.cpp.

I'm hitting #error "WIFI_PASSWORD not defined" on line 32 of main.cpp, despite WIFI_SSID being found and both SSID and PASSWORD being set up apparently correctly. I'm sure it will be something I'm doing wrong, but if not and I find anything in the code I'll let you know.

Thanks.

hptechdesign commented 1 year ago

An update on my remaining error - it is not an issue with your code.

There is however a limitation in CMake's _target_compiledefinitions which looks to be causing an issue with at least one of the special characters ('#') in my WiFI password - more details here: https://cmake.org/cmake/help/latest/prop_tgt/COMPILE_DEFINITIONS.html

I'll work around this but it might be worth adding a comment somewhere as it may catch others out too.

All best, Huw

jondurrant commented 1 year ago

Ow that is pain. You could just hard code the password into main. I just try to avoid that as don't want to place my password on GitHub.

On Tue, May 2, 2023 at 7:54 AM Huw Price @.***> wrote:

An update on my remaining error - it is not an issue with your code.

There is however a limitation in CMake's target_compile_definitions which looks to be causing an issue with at least one of the special characters ('#') in my WiFI password - more details here: https://cmake.org/cmake/help/latest/prop_tgt/COMPILE_DEFINITIONS.html http://url

I'll work around this but it might be worth adding a comment somewhere as it may catch others out too.

All best, Huw

— Reply to this email directly, view it on GitHub https://github.com/jondurrant/RPI-PicoW-WolfSSL-Exp/issues/1#issuecomment-1530974398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWFSB47OS3NLOGCAMXBWKLXECVR7ANCNFSM6AAAAAAXSRYFXY . You are receiving this because you modified the open/close state.Message ID: @.***>