search

jonegil / gui-with-gio

Tutorials for Gio, the GUI framework in Go.
https://jonegil.github.io/gui-with-gio/
Other
193 stars 40 forks source link

First couple of proofreading pages completed. #12

Closed BuckeyeCoder closed 2 years ago

BuckeyeCoder commented 2 years ago

BTW, I'm Geek Stocks in case you're wondering WTF? (That's "WHO the fuck?") lol

I'm not sure when I'll have time again to proofread so I'm submitting these now. Mostly minor stuff; one broken link. I do intend to get to all of the site as I have time.

One important note for you to consider though. The demo at the end of Chapter 1 does not contain an os.Exit(0) line. When the student clicks the window frame's X to exit the app, the window goes away but the process still hangs in the terminal.

Now, you may know that already and it may be intentional for all I know. If it is, I agree with your call, because I'm pretty sure the added complexity to get the os.Exit(0) line into the right place would defeat the goal of keeping this chapter SIMPLE.

BUT, if that IS your reason then my opinion is that you need to do an "information" or "warning" callout at the end of the chapter. The hung process looks bad and makes the project look bad for producing a "failed" demo. Just a sentence or two telling the student that "its intentional" and just use ctrl-c to exit the process for now. And that you'll fix this issue in Chapter X (I haven't looked but it does get fixed.)

Something to think about. I didn't propose anything because I didn't want to presuppose your intentions.

jonegil commented 2 years ago

This is good stuff, thank you for taking the time to read through. I can feel the flow improving when reading your versions. Mine were a bit more staccato, yours more natural. Apprecated.

Cheers!