jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
55 stars 52 forks source link

move analysis code from HNN GUI to start hnn_core.analysis submodule #139

Closed blakecaldwell closed 3 months ago

blakecaldwell commented 4 years ago

Purpose: To make code that was previously only in HNN GUI dual-purpose and serve for the analysis of simulations run by hnn-core from the command-line.

Rationale: Since HNN GUI will import hnn-core already for hnn_core.simulator to run the NEURON solver, this will be a better home for the analysis functions. These functions will benefit from documentation and unit testing as part of hnn-core

Proposed components:

In addition to moving the code, the following improvments will be made:

blakecaldwell commented 4 years ago

It's not clear whether optimization code should go entirely in analysis, or the wrapper that runs code in hnn_core.simulator should also go in hnn_core.simulator.

jasmainak commented 4 years ago

@blakecaldwell can you cross-link to already open pull requests and issues? For e.g., for rmse we already have a pull request and also for LFP/CSD.

ntolley commented 3 months ago

Going through the list all of these have actually been implemented in some capacity!