Closed blakecaldwell closed 3 months ago
It's not clear whether optimization code should go entirely in analysis, or the wrapper that runs code in hnn_core.simulator
should also go in hnn_core.simulator
.
@blakecaldwell can you cross-link to already open pull requests and issues? For e.g., for rmse
we already have a pull request and also for LFP/CSD.
Going through the list all of these have actually been implemented in some capacity!
Purpose: To make code that was previously only in HNN GUI dual-purpose and serve for the analysis of simulations run by
hnn-core
from the command-line.Rationale: Since HNN GUI will import
hnn-core
already forhnn_core.simulator
to run the NEURON solver, this will be a better home for the analysis functions. These functions will benefit from documentation and unit testing as part ofhnn-core
Proposed components:
hnn_core.simulator
(#150)In addition to moving the code, the following improvments will be made: