[MRG] Added return rmse to optimize_evoked

[klankinen]

Now optimize_evoked returns the unweighted RMSE values for each optimization iteration.

[codecov-commenter]

Codecov Report

Merging #610 (0055cf5) into master (e56e7ab) will increase coverage by 0.01%. The diff coverage is 97.22%.

:exclamation: Current head 0055cf5 differs from pull request most recent head 26a798b. Consider uploading reports for the commit 26a798b to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
+ Coverage   92.01%   92.02%   +0.01%     
==========================================
  Files          22       22              
  Lines        4257     4202      -55     
==========================================
- Hits         3917     3867      -50     
+ Misses        340      335       -5     

Impacted Files	Coverage Δ
hnn_core/__init__.py	100.00% <ø> (ø)
hnn_core/network.py	93.34% <ø> (ø)
hnn_core/network_models.py	100.00% <ø> (ø)
hnn_core/gui/_viz_manager.py	88.92% <66.66%> (+0.31%)	:arrow_up:
hnn_core/dipole.py	92.45% <100.00%> (ø)
hnn_core/drives.py	98.54% <100.00%> (+6.05%)	:arrow_up:
hnn_core/gui/gui.py	96.42% <100.00%> (-0.04%)	:arrow_down:
hnn_core/optimization.py	92.48% <100.00%> (-0.27%)	:arrow_down:
hnn_core/parallel_backends.py	81.38% <0.00%> (-1.67%)	:arrow_down:
hnn_core/cell_response.py	84.00% <0.00%> (-0.54%)	:arrow_down:
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[klankinen]

Added comments.

[jasmainak]

Other than tiny comment, looks good. Could you update whats_new.rst ? And edit the PR title to [MRG] to indicate it's ready from your end !

[klankinen]

Slight modification to the documentation

[jasmainak]

Thank you! and whats_new.rst ? For giving appropriate credit ...

[rythorpe]

Aside from a few minor comments, this looks really good @klankinen! It also looks like the link you added to whats_new.rst is broken and causing the linkcheck to fail.

[jasmainak]

Thanks @klankinen ! :partying_face: Looking forward to your next contribution :smiley:

[klankinen]

Thanks @jasmainak and @rythorpe!