ntolley commented 1 year ago

Found by @wagdy88, adding an evoked drive with only NMDA weights threw an error. Solution was fixing a typo in _get_target_properties()

codecov-commenter commented 1 year ago

Codecov Report

Merging #611 (19f5538) into master (a4493c1) will decrease coverage by 0.08%. The diff coverage is n/a.

:exclamation: Current head 19f5538 differs from pull request most recent head cee9fbe. Consider uploading reports for the commit cee9fbe to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
- Coverage   92.03%   91.96%   -0.08%     
==========================================
  Files          22       22              
  Lines        4256     4256              
==========================================
- Hits         3917     3914       -3     
- Misses        339      342       +3

Impacted Files	Coverage Δ
hnn_core/drives.py	`92.48% <ø> (ø)`
hnn_core/parallel_backends.py	`82.22% <0.00%> (-0.84%)`	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jasmainak commented 1 year ago

Oh boy ...

do you want to update whats_new.rst @ntolley ?

ntolley commented 1 year ago

Oops forgot to push that doc change, should be all set now!

rythorpe commented 1 year ago

Thanks @ntolley!

jonescompneurolab / hnn-core

[MRG] BUG: Allow adding drives with just NMDA weights #611

Codecov Report