jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
55 stars 52 forks source link

[MRG] Fix legacy param reading for legacy_mode=False #614

Closed ntolley closed 1 year ago

ntolley commented 1 year ago

@rythorpe @jasmainak I think I figured out the issue with creating a network from a params file when legacy_mode=False. In the file there are "dummy drives" where the tstart comes after tstop so that the drive never occurs in the simulation.

I just added a conditional statement to skip over these drives when they come up, if you see a more elegant solution let me know!

codecov-commenter commented 1 year ago

Codecov Report

Merging #614 (7c32057) into master (b9a09d8) will increase coverage by 0.05%. The diff coverage is 75.00%.

:exclamation: Current head 7c32057 differs from pull request most recent head 349008e. Consider uploading reports for the commit 349008e to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage   92.14%   92.19%   +0.05%     
==========================================
  Files          22       22              
  Lines        4225     4229       +4     
==========================================
+ Hits         3893     3899       +6     
+ Misses        332      330       -2     
Impacted Files Coverage Δ
hnn_core/drives.py 97.87% <75.00%> (-0.67%) :arrow_down:

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jasmainak commented 1 year ago

Thanks @ntolley !! This is great! @chenghuzi do you think you can use this in the GUI now?!