search

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
55 stars 52 forks source link

[MRG] DOC: add template for reporting installation issues #630

Closed jasmainak closed 1 year ago

jasmainak commented 1 year ago

I see myself asking the same questions to people when they report their installation issues. We can iterate and refine this as we get more complaints ...

codecov-commenter commented 1 year ago

Codecov Report

Merging #630 (834b334) into master (6f5ee19) will increase coverage by 0.24%. The diff coverage is 100.00%.

:exclamation: Current head 834b334 differs from pull request most recent head 7fe83c7. Consider uploading reports for the commit 7fe83c7 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
+ Coverage   91.95%   92.19%   +0.24%     
==========================================
  Files          22       22              
  Lines        4276     4282       +6     
==========================================
+ Hits         3932     3948      +16     
+ Misses        344      334      -10
Impacted Files Coverage Δ
hnn_core/__init__.py 100.00% <100.00%> (ø)
hnn_core/optimization.py 94.85% <100.00%> (+2.37%) :arrow_up:

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rythorpe commented 1 year ago

Is there a proper way to view the new template? The text looks good besides...

jasmainak commented 1 year ago

Not that I know of ... I could have enabled discussions on my repo and pushed on master branch but that seems more work than necessary. I think the easiest is to merge to see it in action

rythorpe commented 1 year ago

Is it ready to merge?

jasmainak commented 1 year ago

yep!

rythorpe commented 1 year ago

Thanks @jasmainak!

jasmainak commented 1 year ago

ughgh: https://github.com/jonescompneurolab/hnn-core/blob/master/.github/DISCUSSION_TEMPLATE/installation.yml ... will follow up

jasmainak commented 1 year ago

see: https://github.com/jonescompneurolab/hnn-core/commit/b833ca683bd59908988d0a1b4969183a7da31ce0