jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
55 stars 52 forks source link

cell response raster plots should show all neurons in the network model #658

Closed jasmainak closed 3 months ago

jasmainak commented 1 year ago

As discussed in the group meeting, we should show all neurons, not just the neurons that spike.

jasmainak commented 1 year ago

Also we should use: https://matplotlib.org/3.1.1/api/_as_gen/matplotlib.pyplot.eventplot.html instead of scatter as mentioned by @ntolley

samadpls commented 7 months ago

@jasmainak, Can I take this issue, and Could you provide me with more context regarding this issue?

jasmainak commented 7 months ago

it's related to this function: https://jonescompneurolab.github.io/hnn-core/stable/generated/hnn_core.CellResponse.html#hnn_core.CellResponse.plot_spikes_raster

when some cells do not spike, this plot omits those cell types. Instead, we want to always plot every cell type.