Closed rythorpe closed 11 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
a8df9a0
) 91.42% compared to head (c64f9b9
) 91.42%.:exclamation: Current head c64f9b9 differs from pull request most recent head baaa882. Consider uploading reports for the commit baaa882 to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We're now getting the same matplotlib error for the ubuntu build as with the windows build: FAILED hnn_core/tests/test_viz.py::test_network_visualization - AttributeError: 'FigureCanvasAgg' object has no attribute 'button_press_event'
. Any idea how to fix this @jasmainak?
looks like they've changed their API slightly. See this example:
https://matplotlib.org/stable/gallery/event_handling/coords_demo.html
we need to update our test. If it's used outside of tests, we may need some if
/else
how MNE does it:
Hmm, this is looking a bit more involved than I was expecting. I'll need to orient myself with the GUI code more before proceeding - if anyone wants to give it a shot, go for it. Otherwise, I'll try to tackle it next week.
I moved all the other stuff about fixing the recent dependency breakage to #678 so that we can move forward with this PR despite the tests not passing.
Feel free to merge whenever you're ready @ntolley!
Looks like I don't have the right permissions to merge! @jasmainak can you merge when the tests are failing? Or is this hard-coded in our security settings
Any update here @jasmainak?
I over-rode the failing test and merged. Thanks @rythorpe for the PR ! Let's try to fix the failing test as soon as we can
fixes #676